Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where PascalCase for strings with numbers was incorrect #151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DingoEatingFuzz
Copy link
Contributor

When the AST transformer generates component invocation nodes, it would handle numbers in paths incorrectly when converting to pascal case.

Before

components/this-is-number-2 -> <ThisIsNumber2 />

After

components/this-is-number-2 -> <ThisIsNumber_2 />

@josemarluedke
Copy link
Owner

@DingoEatingFuzz could you rebase this branch when you have the opportunity? Thanks.

When the AST transformer generates component invocation nodes, it would
handle numbers in paths incorrectly when generating pascal case.

Before: this-is-number-2 -> ThisIsNumber2
After:  this-is-number-2 -> ThisIsNumber_2
@DingoEatingFuzz
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants